Skip to content

Conversation

yepher
Copy link
Contributor

@yepher yepher commented Jan 14, 2022

Adds PC Fan Element. This is based on wokwi/wokwi-features#132

Copy link
Collaborator

@urish urish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promising, thank you!

export { DipSwitch8Element } from './dip-switch-8-element';
export { StepperMotorElement } from './stepper-motor-element';
export { HX711Element } from './hx711-element';
export { PcFanElement } from './pc-fan-element';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be PCFanElement

title: 'PC Fan',
component: 'wokwi-pc-fan',
argTypes: {
angle: { control: { type: 'number', min: 0, max: 360, step: 1 } },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using a "range" type for the control? I think it'll be more user friendly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants