forked from me-foundation/magicdrop
-
Notifications
You must be signed in to change notification settings - Fork 0
erc1155 self serve contracts #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wolfy-nft
wants to merge
39
commits into
adam/feat/selfserve
Choose a base branch
from
adam/feat/selfserve_1155
base: adam/feat/selfserve
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
…gicdrop into adam/feat/selfserve_1155 Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
…gicdrop into adam/feat/selfserve_1155
…gicdrop into adam/feat/selfserve_1155
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
…gicdrop into adam/feat/selfserve_1155 Signed-off-by: Adam Wolf <wolfynft@gmail.com>
…gicdrop into adam/feat/selfserve_1155
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Tests
19 new test cases added for

ERC1155MagicDropCloneable35 new tests added for

ERC1155MagicDropMetadataCloneablecode coverage. both should be 100% but theres an lcov bug causing missing coverage on two lines
