Skip to content

[πŸš€ 사이클2 - λ―Έμ…˜ (λΈ”λž™μž­ κ²Œμž„ μ‹€ν–‰)] ν”Όλ…Έ λ―Έμ…˜ μ œμΆœν•©λ‹ˆλ‹€.#1110

Open
haechanmoon wants to merge 64 commits intowoowacourse:haechanmoonfrom
haechanmoon:haechanmoon_step2
Open

[πŸš€ 사이클2 - λ―Έμ…˜ (λΈ”λž™μž­ κ²Œμž„ μ‹€ν–‰)] ν”Όλ…Έ λ―Έμ…˜ μ œμΆœν•©λ‹ˆλ‹€.#1110
haechanmoon wants to merge 64 commits intowoowacourse:haechanmoonfrom
haechanmoon:haechanmoon_step2

Conversation

@haechanmoon
Copy link

체크 리슀트

  • λ―Έμ…˜μ˜ ν•„μˆ˜ μš”κ΅¬μ‚¬ν•­μ„ λͺ¨λ‘ κ΅¬ν˜„ν–ˆλ‚˜μš”?
  • Gradle testλ₯Ό μ‹€ν–‰ν–ˆμ„ λ•Œ, λͺ¨λ“  ν…ŒμŠ€νŠΈκ°€ μ •μƒμ μœΌλ‘œ ν†΅κ³Όν–ˆλ‚˜μš”?
  • μ• ν”Œλ¦¬μΌ€μ΄μ…˜μ΄ μ •μƒμ μœΌλ‘œ μ‹€ν–‰λ˜λ‚˜μš”?

μ–΄λ–€ 뢀뢄에 μ§‘μ€‘ν•˜μ—¬ 리뷰해야 ν• κΉŒμš”?

μ•ˆλ…•ν•˜μ„Έμš”! ν”Όλ…Έμž…λ‹ˆλ‹€. λ‘λ²ˆμ§Έ 사이클 κΈ°λŠ₯ κ΅¬ν˜„ μ™„λ£Œν–ˆμŠ΅λ‹ˆλ‹€.! μ œκ°€ 사이클1에 λ°°νŒ…κΈ°λŠ₯을 μΆ”κ°€ν•˜λ©΄μ„œ ꡉμž₯히 λ§Žμ€ μ½”λ“œλ“€μ„ μˆ˜μ •ν•΄μ•Ό ν–ˆμŠ΅λ‹ˆλ‹€. μ œκ°€ μ½”λ“œλ₯Ό μˆ˜μ •ν•˜λ©΄μ„œ κ°€μž₯ 많이 λ“€μ—ˆλ˜ 생각은 λ³€κ²½ μš©μ΄ν•œ μ½”λ“œ μž…λ‹ˆλ‹€! μš”κ΅¬μ‚¬ν•­μ΄ λ°”λ€Œμ—ˆμ„ λ•Œ μ–΄λ–»κ²Œ ν•˜λ©΄ λ³€κ²½ μš©μ΄ν•œ μ½”λ“œλ₯Ό μž‘μ„±ν•  수 μžˆμ„μ§€ 고민을 ν–ˆμŠ΅λ‹ˆλ‹€. μ²˜μŒλΆ€ν„° λ³€κ²½ μš©μ΄ν•œ μ½”λ“œλ₯Ό μž‘μ„±ν–ˆλ”λΌλ©΄ λ§Žμ€ μˆ˜μ •μ„ ν•˜μ§€ μ•Šμ•˜μ–΄λ„ 됐을 것 κ°™μŠ΅λ‹ˆλ‹€.

리뷰 잘 λΆ€νƒλ“œλ¦¬κ² μŠ΅λ‹ˆλ‹€!

Copy link
Member

@Arachneee Arachneee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ•ˆλ…•ν•˜μ„Έμš” ν”Όλ…Έ~

2단계 λ―Έμ…˜ν•˜λŠλΌ κ³ μƒν•˜μ…¨μ–΄μš”!

λ―Έμ…˜ μš”κ΅¬μ‚¬ν•­ λ‹€μ‹œ ν™•μΈν•΄μ£Όμ„Έμš”! BLACK_JACK으둜 μ΄κΈ°λŠ” μΌ€μ΄μŠ€κ°€ μ—†λ„€μš”

Comment on lines +43 to +52
int finalIncomeMoney = gambler.calculateFinalIncome(dealer);
gamblersResult.put(name, finalIncomeMoney);
}
return gamblersResult;
}

public int dealerFinalIncome(Dealer dealer) {
int dealerFinalIncome = 0;
for (Gambler gambler : gamblers) {
MatchResult result = gambler.getResult(dealer);
if (result == MatchResult.WIN) {
loseCount++;
}
if (result == MatchResult.LOSE) {
winCount++;
}
logs.add(gambler.showResult(result));
dealerFinalIncome += gambler.calculateFinalIncome(dealer);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gambler.calculateFinalIncome(dealer) λ₯Ό μ€‘λ³΅μœΌλ‘œ κ³„μ‚°ν•΄μ•Όν•˜λŠ” 게 λΉ„νš¨μœ¨μ μΈ 것 κ°™μ•„μš”.

Gamblersκ°€ κΌ­ μ΅œμ’… λ°°νŒ… κ²°κ³ΌκΉŒμ§€ κ³„μ‚°ν•΄μ•Όν• κΉŒμš”? getterλ₯Ό μ•ˆμ“°κΈ° μœ„ν•΄ 이런 λ©”μ†Œλ“œλ₯Ό λ§Œλ“  것 κ°™μ•„μš”.

GamblersλŠ” μ–΄λ–€ κΈ°λŠ₯κΉŒμ§€ μ œκ³΅ν•˜λŠ” 것이 μ’‹μ„κΉŒ? λ₯Ό 고민해보면 쒋을 것 κ°™μ•„μš”.

getterλŠ” μ•ˆμ»μ§€λ§Œ 였히렀 Gamblers와 Dealer의 μ˜μ‘΄μ„±μ΄ 생기고 λ°°νŒ… κ²°κ³ΌκΉŒμ§€ κ³„μ‚°ν•˜λ©΄μ„œ μ±…μž„μ΄ 더 μ»€μ‘Œμ–΄μš”.

Comment on lines +6 to +7
public class BettingMoney {
private final int money;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BettingMoneyλ₯Ό μ›μ‹œκ°’ 포μž₯ν–ˆκ΅°μš” πŸ‘

BettingMoneyκ°€ VO 되렀면 μ–΄λ–€ 쑰건이 ν•„μš”ν• κΉŒμš”?

return name;
}

public int calculateIncome(BettingMoney bettingMoney) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ μ ˆν•œ λ©”μ†Œλ“œλ„€μš”! πŸ‘

return PlayerNameParser.splitNames(InputView.readLine());
}

private List<Gambler> createGambler() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GamblersκΉŒμ§€ λ§Œλ“€μ–΄λ„ 쒋을 것 κ°™μ•„μš”!

Comment on lines +15 to +17
@ParameterizedTest
@ValueSource(ints = {999, 0, -999, -2000})
@DisplayName("1000 미만 숫자 μž…λ ₯ μ‹œ 였λ₯˜λ°œμƒ")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

WIN("승"),
LOSE("패"),
DRAW("무");
BLACKJACK("λΈ”λž™μž­", 1.5),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BLACKJACK으둜 μ΄κΈ°λŠ” κ²½μš°κ°€ μ—†μ–΄μš”~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants