Fix reader feed image display for video card types #22364
Closed
+39
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- VIDEO cards now show featured images when available - Updated buildFeaturedImageVisibility() to support VIDEO cards with images - Updated buildFeaturedImageUrl() for consistent behavior across card types - Added comprehensive unit tests for VIDEO card image display - Fixes issue where VIDEO posts with thumbnails didn't show images Fixes #21332
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | WordPress | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22364-064cce1 | |
| Commit | 064cce1 | |
| Direct Download | wordpress-prototype-build-pr22364-064cce1.apk |
Contributor
|
| App Name | Jetpack | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22364-064cce1 | |
| Commit | 064cce1 | |
| Direct Download | jetpack-prototype-build-pr22364-064cce1.apk |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #22364 +/- ##
=======================================
Coverage 39.03% 39.03%
=======================================
Files 2203 2203
Lines 106316 106318 +2
Branches 15057 15057
=======================================
+ Hits 41499 41500 +1
Misses 61328 61328
- Partials 3489 3490 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adalpari
deleted the
fix/Fix-Reader-feed-image-display-for-VIDEO-card-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a contribution PR from #22325 :
Fixes #21332
Description
Testing instructions