Conversation
fluiddot
commented
Dec 21, 2023
| "eslint-plugin-import": "2.25.2", | ||
| "eslint-plugin-jest": "27.2.1", | ||
| "eslint-plugin-jsdoc": "^39.6.9", | ||
| "eslint-plugin-jsdoc": "^46.4.6", |
Contributor
Author
There was a problem hiding this comment.
This dependency has been updated to support node 20.
Comment on lines
-10
to
+11
| "node": ">=16.0.0", | ||
| "npm": ">=8 <9" | ||
| "node": ">=20.10.0", | ||
| "npm": ">=10.2.3" |
Contributor
Author
There was a problem hiding this comment.
This configuration matches the one used in Gutenberg (reference).
geriux
approved these changes
Dec 21, 2023
Contributor
geriux
left a comment
geriux
left a comment
There was a problem hiding this comment.
LGTM! Thanks for updating these, I've smoke-tested the demo app and all of the CI jobs passed correctly 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up on the Gutenberg PR WordPress/gutenberg#56331 to update Node to the same version used in Gutenberg.
More information can be found in:
https://make.wordpress.org/core/2023/12/20/updating-wordpress-to-use-more-modern-versions-of-node-js-npm-2/
Jetpack repository
No updates are needed as it already uses node 20 (reference).
Block Experiments repository
It currently uses node 16, so eventually we'd need to update it (reference). Similar to what happened in GBM, we need to update the dependency
eslint-plugin-jsdoc. Since the affected package is not strictly related to editor/block logic, looks safe to continue this PR without updating node in this repository.In any case, I opened Automattic/block-experiments#340 as a follow-up.
To test:
PR submission checklist: