Skip to content

Conversation

@kimurash
Copy link
Member

@kimurash kimurash commented Jul 5, 2025

Issue

目的

見やすくするため

やったこと

タイトル参照

動作確認

けいすけに直接見せる

@kimurash kimurash requested a review from Copilot July 5, 2025 02:36
@kimurash kimurash self-assigned this Jul 5, 2025
@kimurash kimurash added the frontend frontend label Jul 5, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR switches feedback rendering to markdown, updates a character’s question count, and adds a necessary dependency.

  • Render general feedback using react-markdown instead of raw text.
  • Reduce Yuzu's totalQuestion from 5 to 1.
  • Add react-markdown to project dependencies.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
frontend/src/webview/src/screens/general-feedback-screen/components/FeedbackBox.tsx Replace Typography with ReactMarkdown for markdown support
frontend/src/webview/src/data/create-characters.ts Change Yuzu's totalQuestion from 5 to 1 and reorder imports
frontend/package.json Add react-markdown dependency
Comments suppressed due to low confidence (1)

frontend/src/webview/src/data/create-characters.ts:12

  • The totalQuestion value for Yuzu was changed from 5 to 1, which alters core behavior. Ensure existing unit and integration tests are updated or added to cover this new question count.
      totalQuestion: 1,

Copy link
Member

@cercil0605 cercil0605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正してマージ

@kimurash kimurash merged commit f0f1bc3 into develop Jul 5, 2025
9 checks passed
@kimurash kimurash deleted the frontend/218-overall-review-markdown branch July 5, 2025 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

総評のMarkdownをレンダリングする

3 participants