サービス名と夢のデザインを変更した #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the UI design and functionality of the dreams feature by modifying the card designs, implementing a confetti effect when a dream is published, and updating the service name from "Dream Sink" to "Dream Base".
- Updated card styling and interactions on public and personal dream cards
- Introduced confetti effect triggered on publishing a dream
- Updated service name and asset paths across components and documentation
Reviewed Changes
Copilot reviewed 19 out of 21 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/pages/dreams/public/card/PublicDreamCard.tsx | Redesigned card styling by removing decorative elements and enhancing UI. |
| frontend/src/pages/dreams/mine/card/MyDreamPrivacyButton.tsx | Modified update function signature to pass the published dream ID as a param. |
| frontend/src/pages/dreams/mine/card/MyDreamCard.tsx | Added confetti effect for published dreams and updated card layout. |
| frontend/src/pages/dreams/mine/MyDreamPage.tsx | Updated state management for published dream ID to support confetti logic. |
| frontend/src/pages/dreams/mine/MyDreamCards.tsx | Passed publishedDreamId prop down to cards and mapped dream items. |
| frontend/src/pages/dreams/components/header/Header.tsx | Changed service name and updated event listeners with consistent quoting. |
| frontend/src/pages/dreams/components/SakuraScatterEffect.tsx | Updated asset paths for sakura images. |
| frontend/index.html | Updated title to match new service name. |
| README.md | Updated service name. |
| .github/PULL_REQUEST_TEMPLATE.md | Modified section header. |
Files not reviewed (2)
- frontend/package.json: Language not supported
- frontend/pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
frontend/src/pages/dreams/mine/MyDreamCards.tsx:41
- If each dream has a unique identifier, use dream.id as the key instead of the index to ensure stability during re-renders.
key={index}
Hikaribamboo
reviewed
May 6, 2025
Hikaribamboo
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
やったこと
スクリーンショット