Skip to content

Ruby 3.2+ Compatibility Updates #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kitcommerce wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ruby 3.2+ Compatibility Updates #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/services/workarea/zipco/checkout.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def complete
if result == "referred"
order.set_zipco_referred_at!
else
order.update_attributes(zipco_referred_at: nil)
order.update(zipco_referred_at: nil)
end

order.user_id = user.try(:id)
Expand Down
2 changes: 1 addition & 1 deletion app/services/workarea/zipco/setup.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def set_checkout_data

payment.set_zipco(token: create_order_response.zipco_order_id)

order.update_attributes!(zipco_order_id: create_order_response.zipco_order_id)
order.update!(zipco_order_id: create_order_response.zipco_order_id)
end

def redirect_uri
Expand Down
4 changes: 2 additions & 2 deletions test/integration/workarea/storefront/zipco_integration_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def test_start_clears_credit_card
def test_cancel_removes_zipco
payment = Payment.find(order.id)

order.update_attributes(zipco_order_id: '1234')
order.update(zipco_order_id: '1234')

payment.set_zipco(token: '1234')

Expand All @@ -112,7 +112,7 @@ def test_cancel_removes_zipco
def test_decline_removes_zipco
payment = Payment.find(order.id)

order.update_attributes(zipco_order_id: '1234')
order.update(zipco_order_id: '1234')

payment.set_zipco(token: '1234')

Expand Down
2 changes: 1 addition & 1 deletion test/services/workarea/zipco/order_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ def test_to_h
payment = Workarea::Payment.find(order.id)

payment = Workarea::Payment.find(order.id)
payment.profile.update_attributes!(store_credit: 2.00)
payment.profile.update!(store_credit: 2.00)
payment.set_store_credit
payment.tenders.first.amount = 2.to_m
payment.save
Expand Down
1 change: 1 addition & 0 deletions workarea-zipco.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,5 @@ Gem::Specification.new do |spec|
spec.files = `git ls-files`.split("\n")

spec.add_dependency 'workarea', '>= 3.4.x'
spec.required_ruby_version = ['>= 2.7', '< 3.5']
end
Loading