Skip to content

Conversation

@j-madrone
Copy link
Collaborator

… and made installation instructions simpler

Fixes #9

current version of pip (25.2) has a vulnerability which causes the precommit to fail. Will upgrade as soon as new version is released

Copilot AI review requested due to automatic review settings October 16, 2025 01:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses dependency issues and simplifies the installation process. The key changes include adding a missing urllib3 dependency and streamlining installation instructions to use a single make install command. Additionally, a temporary workaround is applied for a pip vulnerability (GHSA-4xh5-x5gv-qwph) until a patched version is released.

Key Changes:

  • Added urllib3 as an explicit dependency to resolve missing package issues
  • Simplified installation instructions by removing verbose alternative methods
  • Added pip vulnerability ignore flag in pre-commit configuration as temporary measure

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
pyproject.toml Added urllib3>=2.5.0 to project dependencies
README.md Simplified installation instructions to single make install command
Makefile Added helpful post-installation messages for users
.pre-commit-config.yaml Added temporary ignore flag for pip vulnerability GHSA-4xh5-x5gv-qwph

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

github-actions bot commented Oct 16, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
__init__.py52296%10–11
cli
   __init__.py440100% 
   containers.py270100% 
cli/commands
   __init__.py00100% 
   api_clients.py286996%24, 297, 442–443, 476, 486, 576, 607, 615
   api_collections.py253398%25, 178, 340
   assets.py46295%51–52
   connections.py520599%578, 580, 586, 624, 973
   data_tables.py163596%28, 248, 262, 316–317
   guide.py166199%106
   init.py850100% 
   profiles.py1970100% 
   properties.py95198%18
   pull.py171298%190–191
   workspace.py38294%57, 67
cli/commands/connectors
   __init__.py00100% 
   command.py88297%103, 152
   connector_manager.py203498%176, 292, 300–301
cli/commands/projects
   __init__.py00100% 
   command.py2691096%353–356, 367, 433–435, 485, 489
   project_manager.py166795%48, 66, 263–264, 276, 317, 325
cli/commands/push
   __init__.py00100% 
   command.py132496%101, 104, 222, 300
cli/commands/recipes
   __init__.py00100% 
   command.py423997%113, 129–130, 267–270, 397, 703
   validator.py6991697%174, 870, 1123, 1210, 1300–1302, 1398–1399, 1458–1459, 1648–1649, 1677–1679
cli/utils
   __init__.py30100% 
   exception_handler.py198696%137, 184, 211, 238, 295, 330
   gitignore.py140100% 
   ignore_patterns.py230100% 
   spinner.py430100% 
   version_checker.py135695%24, 26, 33–34, 72, 102
cli/utils/config
   __init__.py50100% 
   manager.py4541397%125, 136–138, 141, 154, 330, 454, 668, 826–827, 888, 947
   models.py330100% 
   profiles.py3091096%93, 189–190, 193, 228–230, 255–257
   workspace.py680100% 
TOTAL540811997% 

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@j-madrone j-madrone requested a review from oalami October 16, 2025 01:16
@oalami oalami merged commit d41a3ba into main Oct 16, 2025
5 checks passed
@oalami oalami deleted the issue-9-python-venv-install-missing-urllib3 branch October 16, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Install] Python venv install missing urllib3

3 participants