-
Notifications
You must be signed in to change notification settings - Fork 6
Clarify --restart-recipes flag behavior and change default to false #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The --restart-recipes flag allows restarting of running recipes that are updated during import, but does not force stopped recipes to restart. This was not clear from the help text and documentation. Changes: - Changed default from true to false (breaking change - more conservative) - Updated help text to clarify that stopped recipes remain stopped - Added inline comments in documentation to explain behavior - Updated test to reflect new default value Users who want to allow recipe restarts must now explicitly use: workato push --restart-recipes 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR changes the default behavior of the --restart-recipes flag in the push command from True to False, making recipe restart an opt-in feature rather than opt-out. The help text is also updated to clarify that the flag only allows restarting of running recipes that were updated, while stopped recipes remain stopped.
Key Changes
- Changed
--restart-recipesdefault fromTruetoFalsein the push command - Updated help text to clarify that the flag allows restarting running recipes, and stopped recipes remain stopped
- Updated test expectations to align with the new default value
- Updated documentation to reflect the new default behavior and add clarifying comments
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/workato_platform_cli/cli/commands/push/command.py |
Changed --restart-recipes default to False and updated help text to clarify behavior |
tests/unit/commands/push/test_command.py |
Updated test assertion to expect False as default value for restart_recipes |
docs/USE_CASES.md |
Added comments clarifying that --restart-recipes only restarts running recipes |
docs/COMMAND_REFERENCE.md |
Updated documentation to note recipes won't restart by default and clarified behavior; fixed trailing whitespace |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
oalami
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
The
--restart-recipesflag allows restarting of running recipes that are updated during import, but does not force stopped recipes to restart. This was not clear from the help text and documentation, leading to confusion about the expected behavior.Changes
truetofalse(more conservative approach)Behavior
Before:
workato pushwould allow recipe restarts by defaultAfter:
workato pushwill NOT allow recipe restarts by defaultUsers who want to allow restarts must now explicitly use:
This aligns with the Workato API's default behavior and makes the CLI more conservative by default.
Testing
🤖 Generated with Claude Code