Add get_agg() and resolve the issue with one of the test unit function#85
Merged
randrescastaneda merged 18 commits intomainfrom Jan 23, 2026
Merged
Add get_agg() and resolve the issue with one of the test unit function#85randrescastaneda merged 18 commits intomainfrom
randrescastaneda merged 18 commits intomainfrom
Conversation
randrescastaneda
requested changes
Dec 11, 2025
Collaborator
randrescastaneda
left a comment
randrescastaneda
left a comment
There was a problem hiding this comment.
Hi @Tefera19 ,
Make sure that get_agg() is also tested.
R/get_stats.R
Outdated
| format <- match.arg(format) | ||
|
|
||
| # Extract varibale name that don't have "_code" and "_name" suffixes from countries auxiliary table | ||
| df <- get_aux("countries") |
Collaborator
There was a problem hiding this comment.
This is not the right aux file. You need to use one called country_list or something like that. Thanks
Contributor
Author
There was a problem hiding this comment.
The aux file has been replaced with "country_list"
Contributor
Author
|
Test units added for get_agg() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @randrescastaneda , I have created get_agg() and fix the issue in one of the test file.