This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Open
Conversation
tonyfujs
reviewed
Dec 5, 2019
R/povcalnet_iterate.R
Outdated
Comment on lines
+1
to
+26
| # ================================================== | ||
| # project: Iterate to find moentary threshold of percentile | ||
| # Author: Andres Castaneda | ||
| # Dependencies: The World Bank | ||
| # ---------------------------------------------------- | ||
| # Creation Date: 2011-11-25 | ||
| # Modification Date: | ||
| # Script version: 01 | ||
| # References: | ||
| # | ||
| # | ||
| # Output: Data frame | ||
| # ================================================== | ||
|
|
||
| #---------------------------------------------------------- | ||
| # Load libraries | ||
| #---------------------------------------------------------- | ||
|
|
||
| library("tidyverse") | ||
| library("povcalnetR") | ||
|
|
||
|
|
||
| #---------------------------------------------------------- | ||
| # subfunctions | ||
| #---------------------------------------------------------- | ||
|
|
Member
There was a problem hiding this comment.
Use the roxygen2 syntax instead
tonyfujs
reviewed
Dec 5, 2019
Comment on lines
+49
to
+53
| if ((length(country) & length(region)) | | ||
| (!length(country) & !length(region))) { | ||
| stop("you must select either a `region` or a `country`") | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
We could use the asserthat package instead
tonyfujs
suggested changes
Dec 5, 2019
Member
tonyfujs
left a comment
tonyfujs
left a comment
There was a problem hiding this comment.
Hey @randrescastaneda Can you make the changes proposed before I merge into master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.