make genesis respect the config flag for disable_persistence #1902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdwoodbury
commented
Dec 29, 2025
| log_info(format!( | ||
| "Job Results :: Persisted to dB: batch-id={batch_id}" | ||
| )); |
Collaborator
Author
There was a problem hiding this comment.
note that this log was removed. it seems redundant.
| log_info(format!( | ||
| "Job Results :: Persisted to dB: modification_id={modification_id}" | ||
| )); |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the disable_persistence configuration flag in the genesis indexing process to enable testing without database writes. The changes introduce conditional logic to skip database operations when persistence is disabled while maintaining in-memory processing.
Key changes:
- Added conditional checks around all database persistence operations (backup, modifications table cleanup, batch/modification persistence)
- Updated logging to indicate when operations are skipped due to disabled persistence
- Added persistence status to startup logging and warning when using backup source with persistence disabled
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sdwoodbury
changed the title
Collaborator
Author
|
testing found that changes are still getting persisted. needs fixing. |
sdwoodbury
force-pushed
the
sw/fix_genesis_persistence
branch
from
06e5856 to
d04250e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that my genesis tests on the dev cluster inserted the irises and graph links into the CPU database instead of just keeping them in memory (when
SMPC__DISABLE_PERSISTENCEwastrue). we don't really need this flag for production but not having it makes testing significantly more difficult because i would then have to either delete items from the graph or add more irises to the GPU database.This PR adds a separate code path to allow testing without persistence.