chore(connd): more permissive wifi qr parsing #898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pophilpo
approved these changes
Jan 6, 2026
valff
reviewed
Jan 6, 2026
Comment on lines
-109
to
-110
| let (input, _) = tag(";")(input)?; | ||
| let (input, _) = eof(input)?; |
Collaborator
There was a problem hiding this comment.
Are you sure we want to allow arbitrary garbage at the end? Perhaps we only do opt(tag(";")) and keep eof in place?
Contributor
There was a problem hiding this comment.
I think the reasoning here was that the parser takes only the first item anyway, so the garbage will not be processed. But I agree with you here
Collaborator
Author
There was a problem hiding this comment.
yeah, reasoning is what @pophilpo said
as long as we can get the info we need it doesn't matter if whatever comes after is garbage
are there any bad cases you can think of that we will run into without opt(tag(";")) plus eof?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes wifi qr parsing slightly more permissive, as long as we can extract needed information