refactor: adapt to world-id-protocol authenticator refactor#352
Merged
kilianglas merged 9 commits intomainfrom Apr 15, 2026
Merged
refactor: adapt to world-id-protocol authenticator refactor#352kilianglas merged 9 commits intomainfrom
kilianglas merged 9 commits intomainfrom
Conversation
kilianglas
commented
Apr 14, 2026
Comment on lines
397
to
430
| @@ -436,7 +424,7 @@ impl Authenticator { | |||
| attribute: "config".to_string(), | |||
| reason: "Invalid config".to_string(), | |||
| })?; | |||
| let authenticator = CoreAuthenticator::init(seed, config).await?; | |||
| let authenticator = CoreAuthenticator::init(seed, config.into()).await?; | |||
| let (query_material, nullifier_material) = load_cached_materials(paths)?; | |||
| let authenticator = | |||
| authenticator.with_proof_materials(query_material, nullifier_material); | |||
Contributor
Author
There was a problem hiding this comment.
Using config.into() to convert into the new AuthenticatorConfig type. Will add ohttp-related config in the follow-up PR.
Dzejkop
reviewed
Apr 15, 2026
Dzejkop
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
world-id-coredependency to 0.9.0get_packed_account_data→refresh_packed_account_data,generate_single_proof→generate_proof,generate_session_id→build_session_idupstream
generate_proofAPI, simplifying the walletkit proof flowAuthenticatorErrorvariants (IndexerError,UnfullfilableRequest,ResponseValidationError,SessionIdMismatch)load_nullifier_material_from_pathsnow returningResultThere will be a follow-up PR for the ohttp client integration