feat(storage): Add enclave_track to push subscription table #140
Open
Takaros999 wants to merge 3 commits intomainfrom
Open
feat(storage): Add enclave_track to push subscription table #140Takaros999 wants to merge 3 commits intomainfrom
Takaros999 wants to merge 3 commits intomainfrom
Conversation
Add enclave track version identifier to push subscriptions to support multi-enclave track architecture. This enables routing notifications to the correct enclave based on which track the subscription was created with. Changes: - Add EnclaveTrack enum to common-types with V2 (default) and V3 (placeholder) - Add enclave_track field to PushSubscription struct in backend_storage - Update subscription creation in backend routes - Update all tests to include the new field
Takaros999
requested review from
andy-t-wang,
aurel-fr,
murph and
paolodamico
as code owners
Contributor
Author
|
@cursor review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR part of a bigger feature (DEV-2458) introducing multi-enclave support, essentially allowing multiple enclave sets running at once.
Our current setup assumes we never upgrade our enclave code and that all push ids are encrypted to the same enclave public key.
This PR introduces
enclave_trackto the push storage table, which will be used later to route the notification to the correct enclave.