Merged
Conversation
Takaros999
requested review from
andy-t-wang,
aurel-fr,
murph and
paolodamico
as code owners
aurel-fr
previously approved these changes
Nov 1, 2025
* feat: Implement key exchange (part 2) * PR comments * Lint
Takaros999
changed the title
andy-t-wang
previously approved these changes
Nov 3, 2025
paolodamico
reviewed
Nov 3, 2025
| # Pontifex | ||
| pontifex = { version = "1.1.1" } | ||
| # TODO: update this when we publish 1.2.0 | ||
| pontifex = { git ="https://github.com/worldcoin/pontifex", rev = "0ef1dd634fc751c065d326acf6a81f2ea41f5460" } |
Contributor
There was a problem hiding this comment.
1.1.2 release coming up, worldcoin/pontifex#27 (review)
paolodamico
reviewed
Nov 3, 2025
| /// | ||
| /// # Returns | ||
| /// A verified attestation containing the enclave's public key and the encrypted plaintext in base64 format. | ||
| /// A verified attestation containing the enclave's public key and the ciphertext. |
Contributor
There was a problem hiding this comment.
"the ciphertext" is a bit confusing. can we clarify what this ciphertext is?
Contributor
Author
There was a problem hiding this comment.
left this in purpose generic, because it's a separate module, i think it's obvious where it's called that we seal the key
paolodamico
reviewed
Nov 3, 2025
| pub braze_api_url: Option<String>, | ||
| /// HTTP client configured to use the HTTP proxy for Braze | ||
| pub http_proxy_client: Option<HttpClient>, | ||
| /// Initialization flag |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Initialization flag | |
| /// Whether the enclave has been initialized by creating a private key or receiving a key from another enclave |
paolodamico
reviewed
Nov 3, 2025
| /// Encryption key pair used for encrypting/decrypting push IDs | ||
| pub encryption_keys: Option<KeyPair>, | ||
| /// Ephemeral key pair used for exchanging keys | ||
| pub ephemeral_key_pair: KeyPair, |
Contributor
There was a problem hiding this comment.
shouldn't this be an Option and the key destroyed after use?
Contributor
Author
There was a problem hiding this comment.
good idea, updated
paolodamico
reviewed
Nov 3, 2025
paolodamico
reviewed
Nov 3, 2025
paolodamico
previously approved these changes
Nov 3, 2025
Takaros999
dismissed stale reviews from paolodamico and andy-t-wang
via
d00bd16
paolodamico
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets up enclave state for key exchange:
Depends on: