Open
Conversation
Author
|
@worstone can I have you look at this please? Thanks! |
|
Just wanted to acknowledge seeing this. No timeline, but at least I'm aware of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into a problem getting orders that have a payment_status of "pending". Below is an excerpt of the exception I found in the RestResponse returned from Orders.get().
"ErrorException": {
"ClassName": "BigCommerce4Net.Api.NewtonSoftJsonDeserializerException",
"Message": "Error converting value "pending" to type 'BigCommerce4Net.Domain.PaymentStatus'. Path 'payment_status', line 1, position 950.",
}
Adding an EnumMember to handle "pending" resolves this issue.
More info if you're interested:
I have only recently come across this "pending" status on orders paid with PayPal Express and an order status of Awaiting Payment (7).
This bug has the potential to getting a list of orders. For example I had a few dozen Awaiting Payment orders to process. When calling Orders.Get with a filter of status_id = 7 the response Data was null but the response content was the big ol' JSON response from BigCommerce which contained all the order data.