Adds shortcode_ui_preview filter#769
Open
joseadrian wants to merge 1 commit intowp-shortcake:masterfrom
Open
Conversation
f2e312c to
477f414
Compare
Added `shortcode_ui_preview` filter to give the option to modify the preview in the WYSIWYG.
477f414 to
594c08d
Compare
Member
|
Hi @joseadrian, thanks for contributing. The filter seems reasonable to me. I'm a little suspicious of the new regex in there though. Would you be willing to move that into a utility function and add some test coverage to make sure it handles different shortcode configurations as you expect? Here's the chunk of code I'm looking at. |
Contributor
|
I was actually wondering if there wasn't a simpler way of doing this. We've talked about a few options that might work:
Would either, or a combination of these approaches fit your use case as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
shortcode_ui_previewfilter to give the option to modify the preview in the WYSIWYG.Some people want to have the option not to preview the content parsed in the editor because they might break the content, or use the dashicons instead.
The filter added will allow them to do that: