Allow url field to accept class attribute#810
Open
LC43 wants to merge 2 commits intowp-shortcake:masterfrom
Open
Allow url field to accept class attribute#810LC43 wants to merge 2 commits intowp-shortcake:masterfrom
LC43 wants to merge 2 commits intowp-shortcake:masterfrom
Conversation
this will allow devs to assign classes to specific elements in the admin edit screens.
Contributor
|
I can see how this might be helpful. The only suggestion I have to use some escaping around the class name, so that we have a bit of protection against broken markup or xss. Changing this from |
Author
|
hi @goldenapples , thanks for the suggestion! I've changed the PR accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this will allow devs to assign classes to specific elements in the admin edit screens.
then just