refactor(container)!: split core responsibilities and add resolution engine#1
Open
mdalaminbey wants to merge 3 commits intomasterfrom
Open
refactor(container)!: split core responsibilities and add resolution engine#1mdalaminbey wants to merge 3 commits intomasterfrom
mdalaminbey wants to merge 3 commits intomasterfrom
Conversation
…engine Refactor Container to compose dedicated components: Registry (bindings, aliases, tags), ResolutionEngine (reflection-based autowiring and caching), and CallbackInvoker (DI-aware callback and method invocation). Introduce CircularDependencyException and extend ContainerException and NotFoundException documentation. Add new APIs including bind, singleton, alias, tag, tagged, make, call, set, has, resolved_id, forget_instances, and flush. Implement shared instance caching, alias resolution, and circular dependency detection. Include extensive unit and integration tests covering deep dependency trees, interface and alias chaining, variadic and nullable parameters, visibility handling, and method invocation behavior. BREAKING CHANGE: container internals and resolution flow have been restructured and public APIs expanded/adjusted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor Container to compose dedicated components:
Registry (bindings, aliases, tags),
ResolutionEngine (reflection-based autowiring and caching),
and CallbackInvoker (DI-aware callback and method invocation).
Introduce CircularDependencyException and extend
ContainerException and NotFoundException documentation.
Add new APIs including bind, singleton, alias, tag, tagged,
make, call, set, has, resolved_id, forget_instances, and flush.
Implement shared instance caching, alias resolution,
and circular dependency detection.
Include extensive unit and integration tests covering
deep dependency trees, interface and alias chaining,
variadic and nullable parameters, visibility handling,
and method invocation behavior.
BREAKING CHANGE: container internals and resolution flow
have been restructured and public APIs expanded/adjusted.