feat(validation)!: introduce full request validation subsystem

.gitattributes

@@ -1,2 +1,10 @@
-# Auto detect text files and perform LF normalization
 * text=auto
+
+/.github export-ignore
+/bin export-ignore
+/tests export-ignore
+/.gitignore export-ignore
+/.gitattributes export-ignore
+/phpunit.xml export-ignore
+/phpcs.xml export-ignore
+/README.md export-ignore

.gitignore

@@ -24,3 +24,4 @@ Homestead.json
 .DS_Store
 composer.lock
 phpunit-report.xml
+phpcs-report.xml

phpunit.xml

@@ -8,9 +8,6 @@
         <testsuite name="Unit">
             <directory suffix="Test.php">./tests/Unit</directory>
         </testsuite>
-        <testsuite name="Integration">
-            <directory suffix="Test.php">./tests/Integration</directory>
-        </testsuite>
     </testsuites>
     <coverage processUncoveredFiles="true">
         <include>

src/Contracts/Rule.php

@@ -0,0 +1,50 @@
+<?php
+/**
+ * Rule contract.
+ *
+ * @package WpMVC\RequestValidator\Contracts
+ * @author  WpMVC
+ * @license MIT
+ */
+
+namespace WpMVC\RequestValidator\Contracts;
+
+defined( "ABSPATH" ) || exit;
+
+/**
+ * Interface Rule
+ *
+ * @package WpMVC\RequestValidator\Contracts
+ */
+interface Rule {
+    /**
+     * Get the unique name of the rule.
+     *
+     * @return string
+     */
+    public static function get_name(): string;
+
+    /**
+     * Determine if the validation rule passes.
+     *
+     * @param  string  $attribute
+     * @param  mixed  $value
+     * @return bool
+     */
+    public function passes( string $attribute, $value ): bool;
+
+    /**
+     * Get the validation error message.
+     *
+     * @return string
+     */
+    public function get_message(): string;
+
+    /**
+     * Replace placeholders in the given message.
+     *
+     * @param  string  $message
+     * @return string
+     */
+    public function replace_placeholders( string $message ): string;
+}

src/DateTime.php

@@ -1,159 +1,40 @@
 <?php
+/**
+ * DateTime trait.
+ *
+ * @package WpMVC\RequestValidator
+ * @author  WpMVC
+ * @license MIT
+ */
 
 namespace WpMVC\RequestValidator;
 
 defined( "ABSPATH" ) || exit;
 
 use DateTime as PhpDateTime;
 
+/**
+ * Trait DateTime
+ *
+ * Provides date and time validation and parsing utilities.
+ *
+ * @package WpMVC\RequestValidator
+ */
 trait DateTime {
-    private $format = 'Y-m-d';
-
-    protected function date_validator( string $input_name, string $format = '' ) {
-        if ( ! $this->wp_rest_request->has_param( $input_name ) ) {
-            return;
-        }
-
-        $value = $this->wp_rest_request->get_param( $input_name );
-
-        if ( ! empty( $format ) ) {
-            $this->format = $format;
-        }
-
-        $format = $this->get_format();
-
-        if ( ! empty( $value ) && $this->is_it_valid_date( $value, $format ) ) {
-            return;
-        }
-
-        $this->set_error( $input_name, 'date', [':attribute'], [$input_name] );
-    }
-
-    public function date_equals_validator( string $input_name, $date ) {
-        if ( ! $this->wp_rest_request->has_param( $input_name ) ) {
-            return;
-        }
-
-        $value = $this->wp_rest_request->get_param( $input_name );
-
-        if ( ! empty( $value ) ) {
-            $format = $this->get_format();
-
-            if ( ! $this->is_it_valid_date( $value, $format ) ) {
-                return;
-            }
-
-            $timestamp       = $this->get_timestamp( $date, $format );
-            $input_timestamp = $this->get_timestamp( $value, $format );
-
-            if ( $input_timestamp === $timestamp ) {
-                return;
-            }
-        }
-
-        $this->set_error( $input_name, 'date_equals', [':attribute', ':date'], [$input_name, $date] );
-    }
-
-    public function before_validator( string $input_name, $date ) {
-        if ( ! $this->wp_rest_request->has_param( $input_name ) ) {
-            return;
-        }
-
-        $value = $this->wp_rest_request->get_param( $input_name );
-
-        if ( ! empty( $value ) ) {
-            $format = $this->get_format();
-
-            if ( ! $this->is_it_valid_date( $value, $format ) ) {
-                return;
-            }
-
-            $timestamp       = $this->get_timestamp( $date, $format );
-            $input_timestamp = $this->get_timestamp( $value, $format );
-
-            if ( $input_timestamp < $timestamp ) {
-                return;
-            }
-        }
-
-        $this->set_error( $input_name, 'before', [':attribute', ':date'], [$input_name, $date] );
-    }
-
-    public function after_validator( string $input_name, $date ) {
-        if ( ! $this->wp_rest_request->has_param( $input_name ) ) {
-            return;
-        }
-
-        $value = $this->wp_rest_request->get_param( $input_name );
-
-        if ( ! empty( $value ) ) {
-            $format = $this->get_format();
-
-            if ( ! $this->is_it_valid_date( $value, $format ) ) {
-                return;
-            }
-
-            $timestamp       = $this->get_timestamp( $date, $format );
-            $input_timestamp = $this->get_timestamp( $value, $format );
-
-            if ( $input_timestamp > $timestamp ) {
-                return;
-            }
-        }
-
-        $this->set_error( $input_name, 'after', [':attribute', ':date'], [$input_name, $date] );
-    }
-
-    protected function before_or_equal_validator( string $input_name, $date ) {
-        if ( ! $this->wp_rest_request->has_param( $input_name ) ) {
-            return;
-        }
-
-        $value = $this->wp_rest_request->get_param( $input_name );
-
-        if ( ! empty( $value ) ) {
-            $format = $this->get_format();
-
-            if ( ! $this->is_it_valid_date( $value, $format ) ) {
-                return;
-            }
-
-            $timestamp       = $this->get_timestamp( $date, $format );
-            $input_timestamp = $this->get_timestamp( $value, $format );
-
-            if ( $input_timestamp < $timestamp || $input_timestamp === $timestamp ) {
-                return;
-            }
-        }
-
-        $this->set_error( $input_name, 'before_or_equal', [':attribute', ':date'], [$input_name, $date] );
-    }
-
-    protected function after_or_equal_validator( string $input_name, $date ) {
-        if ( ! $this->wp_rest_request->has_param( $input_name ) ) {
-            return;
-        }
-
-        $value = $this->wp_rest_request->get_param( $input_name );
-
-        if ( ! empty( $value ) ) {
-            $format = $this->get_format();
-
-            if ( ! $this->is_it_valid_date( $value, $format ) ) {
-                return;
-            }
-
-            $timestamp       = $this->get_timestamp( $date, $format );
-            $input_timestamp = $this->get_timestamp( $value, $format );
-
-            if ( $input_timestamp > $timestamp || $input_timestamp === $timestamp ) {
-                return;
-            }
-        }
-
-        $this->set_error( $input_name, 'after_or_equal', [':attribute', ':date'], [$input_name, $date] );
-    }
-
+    /**
+     * The date/time format to use.
+     *
+     * @var string
+     */
+    protected $format = 'Y-m-d';
+
+    /**
+     * Determine if a date string is valid for a given format.
+     *
+     * @param  string  $date
+     * @param  string  $format
+     * @return bool
+     */
     private function is_it_valid_date( $date, string $format ) {
         if ( ! is_string( $date ) ) {
             return false;
@@ -162,29 +43,33 @@ private function is_it_valid_date( $date, string $format ) {
         return $input_date && $input_date->format( $format ) === $date;
     }
 
+    /**
+     * Get the Unix timestamp for a given date string and format.
+     *
+     * @param  string  $date
+     * @param  string  $format
+     * @return int
+     */
     private function get_timestamp( string $date, string $format ) {
-        $date_array = date_parse_from_format( $format, $date );
-        return mktime(
-            ! empty( $date_array['hour'] ) ? $date_array['hour'] : 12,
-            ! empty( $date_array['minute'] ) ? $date_array['minute'] : 0,
-            ! empty( $date_array['second'] ) ? $date_array['second'] : 0,
-            $date_array['month'],
-            $date_array['day'],
-            $date_array['year']
-        );
-    }
+        $request = property_exists( $this, 'validator' ) && $this->validator ? $this->validator->wp_rest_request : $this->wp_rest_request;
+
+        // If the date string matches a parameter in the request, use its value
+        if ( $request->has_param( $date ) ) {
+            $date = $request->get_param( $date );
+        }
+
+        $dt = PhpDateTime::createFromFormat( $format, $date );
+
+        if ( ! $dt ) {
+            return 0;
+        }
 
-    private function get_format() {
-        foreach ( $this->explode_rules as $key => $value ) {
-            $substrings = explode( ':', $value, 2 );
-            if ( $substrings[0] !== 'date' ) {
-                continue;
-            }
-            if ( isset( $substrings[1] ) ) {
-                return $substrings[1];
-            }
-            return $this->format;
+        // If the format doesn't include time components, createFromFormat might set them to current time or '?'
+        // We should ensure a consistent start-of-day for formats without time.
+        if ( strpos( $format, 'H' ) === false && strpos( $format, 'h' ) === false ) {
+            $dt->setTime( 0, 0, 0 );
         }
-        return $this->format;
+
+        return $dt->getTimestamp();
     }
 }