Skip to content

Code inspection warnings #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rpm4 merged 4 commits into from
Jan 12, 2026
Merged

Code inspection warnings #1224

rpm4 merged 4 commits into from
Jan 12, 2026

Conversation

@ddkohler
Copy link
Contributor

@ddkohler ddkohler commented Jan 12, 2026 •
edited
Loading

Implementing suggestions that come from our pytest code inspection.

Changes

  • remove return statements from finally blocks (cf. PEP 765)
  • declare custom pytest marks (only relevant for tests)
  • make sure tests return None (only relevant for tests)

Checklist

  • updated documentation, if applicable
  • updated CHANGELOG.md
  • tests pass

@ddkohler ddkohler marked this pull request as ready for review January 12, 2026 14:59
@rpm4 rpm4 merged commit 6d641c1 into master Jan 12, 2026
9 checks passed
@rpm4 rpm4 deleted the code-inspection-warnings branch January 12, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rpm4 rpm4 rpm4 approved these changes

@untzag untzag Awaiting requested review from untzag untzag is a code owner

@ksunden ksunden Awaiting requested review from ksunden ksunden is a code owner

@darienmorrow darienmorrow Awaiting requested review from darienmorrow darienmorrow is a code owner

@kameyer226 kameyer226 Awaiting requested review from kameyer226 kameyer226 is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ddkohler @rpm4