Skip to content

Conversation

@maruyamayasuaki
Copy link

No description provided.

@acsr
Copy link
Contributor

acsr commented Jun 27, 2025

I can see that the japanese ticket title means "Corrections to the link function".

A related ticket or at least some description of the (maybe and of course obvious) goal of the improvement and how to test would be necessary to proceed without wasting time.

  • Describe the scope of the change.
  • Describe some examples what the change improves and test data that is valid to test.
  • Describe the way you need to setup the test environment.
  • Ideally write an automated test.

As far as I know Zutilo has no CI/CD setup. So you may end up doing it by hand.

@wshanks
Copy link
Owner

wshanks commented Jun 27, 2025

Thanks for commenting, @acsr.

I haven't seen any complaints about the link function so I am also wondering about the intent of the change. The current function now produces broken links and this update fixes it I would merge it. My time for testing and researching Zutilo issues is pretty limited now.

I think we would want to leave the select link code uncommented. Maybe there is some issue with it, but I would rather not just comment it out even if so.

It is right that there is no CI/CD. It would be great to have some. To do it right would take some time (at least for me).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants