Skip to content

Fix policy count increment#1352

Merged
PasanT9 merged 1 commit intowso2:masterfrom
PasanT9:470-7
Apr 19, 2026
Merged

Fix policy count increment#1352
PasanT9 merged 1 commit intowso2:masterfrom
PasanT9:470-7

Conversation

@PasanT9
Copy link
Copy Markdown
Contributor

@PasanT9 PasanT9 commented Apr 19, 2026

Purpose

$subject

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 19, 2026

Caution

Review failed

Pull request was closed or merged during review

Summary

This pull request increases the limit parameter in the listAPIPolicies function from 55 to 100 to ensure all API policies are retrieved when listing policies in integration tests. The change applies to both default and JSON array output formats when calling the get policies API command.

Changes

  • Updated the policy retrieval limit in the test utility function to accommodate a larger number of policies, improving test completeness and reliability.

Walkthrough

The limit parameter in a test utility function was increased from "55" to "100" to allow retrieval of a larger set of API policies during testing.

Changes

Cohort / File(s) Summary
Test Utility Update
import-export-cli/integration/testutils/operationPolicy_testUtils.go
Increased the limit argument in the listAPIPolicies function from "55" to "100" for expanded policy retrieval in tests.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is incomplete and largely unfilled. It only contains a placeholder 'Purpose' section with '$subject' instead of actual content, missing all other required template sections. Fill in the complete pull request description template with Purpose, Goals, Approach, User stories, Release note, Documentation, and other required sections per the repository template.
Title check ❓ Inconclusive The title 'Fix policy count increment' is vague and does not clearly describe what was actually changed. The actual change is increasing the limit from 55 to 100 in a test utility function. Clarify the title to better describe the specific change, such as 'Increase policy limit from 55 to 100 in test utilities' or 'Increase default policy retrieval limit for listAPIPolicies test utility'.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@PasanT9 PasanT9 merged commit 2bfb9d8 into wso2:master Apr 19, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants