Fix cache: Don't check one url multiple times#687
Open
PetrDlouhy wants to merge 4 commits intowummel:masterfrom
Open
Fix cache: Don't check one url multiple times#687PetrDlouhy wants to merge 4 commits intowummel:masterfrom
PetrDlouhy wants to merge 4 commits intowummel:masterfrom
Conversation
Author
|
Travis tests are working, so only tests are waiting. |
PetrDlouhy
force-pushed
the
master
branch
2 times, most recently
from
3e7fc19 to
2b9dafa
Compare
PetrDlouhy
changed the title
Author
|
Now it should be finished. It includes tests for |
|
please reroll this PR in the new organisation here: https://github.com/linkcheck/linkchecker/pulls see #686 for details |
|
would be a great feature to merge into mainstream. Is there any timeplan for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #608, Linkchecker does multiple checks for one URL. It is caused by inconsistent use of cache. The URL is added to the queue when checking page, but it doesn't get to cache until the moment of checking the URL itself. In the meantime, it can be added to queue multiple times.
This PR should fix it.