Use zookeeper watchers to keep brokers list in sync#36
Open
andrewjamesbrown wants to merge 4 commits intomasterfrom
Open
Use zookeeper watchers to keep brokers list in sync#36andrewjamesbrown wants to merge 4 commits intomasterfrom
andrewjamesbrown wants to merge 4 commits intomasterfrom
Conversation
added 4 commits
February 3, 2017 13:31
Since zookeeper watches are more efficient, we use them to manage the broker list instead of forcing the caller to reset metadata to trigger the cache to refresh.
wvanbergen
approved these changes
Jun 13, 2017
Owner
wvanbergen
left a comment
wvanbergen
left a comment
There was a problem hiding this comment.
LATE response, but I like this approach. Is this still something you want to get landed in this gem.
wvanbergen
approved these changes
Jun 13, 2017
Owner
wvanbergen
left a comment
wvanbergen
left a comment
There was a problem hiding this comment.
Does it make sense to use a similar approach for topics and consumergroups? Maybe that will result in keeping to much useless data in memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@psycotica0-shopify and I put this together. We're moving to using zookeeper watches to keep the set of brokers in sync, instead of forcing the caller to reset metadata and keeping our own cache.
Related to #35 (comment)