Fix installation script - Restrict pip version to below 23 during setuptools upgrade#31
Open
Fix installation script - Restrict pip version to below 23 during setuptools upgrade#31
Conversation
Pin pip to versions below 23 to maintain compatibility with older setuptools installation methods. Newer pip versions (23+) removed the --global-option flag which is required by some legacy package installations in the OneDep build process.
lucas-ebi
force-pushed
the
fix-install
branch
from
4f84f30 to
7d65c49
Compare
Author
|
@epeisach looks like |
Contributor
|
This is not sustainable. We need PKG_CONFIG_DIR set before installation. I came across this recently as well... |
lucas-ebi
force-pushed
the
fix-install
branch
from
f258539 to
7d65c49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix pip version compatibility in OneDep installation script
Problem
The OneDep installation script was failing during the setuptools upgrade phase due to compatibility issues with newer versions of pip (23+). These newer versions removed the
--global-optionflag that is required by some legacy package installations in the OneDep build process.Solution
This PR restricts pip to versions below 23 during the setuptools upgrade step to maintain compatibility with the existing OneDep build infrastructure.
Changes
<23during the virtual environment setuppip install --no-cache-dir --upgrade setuptools "pip<23"Testing
Impact
This is a minimal, targeted fix that ensures installation stability while maintaining backward compatibility. The version constraint only affects the installation process and does not impact runtime functionality.