Use 'hints' to select authenticator #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlun
reviewed
Apr 29, 2025
Member
emlun
left a comment
emlun
left a comment
There was a problem hiding this comment.
Looks good! But I see some suspicious byte array encodings that might be (at least part of) the reason things weren't working yesterday...
webview/src/main/java/io/yubicolabs/funke_explorer/bridging/WalletJsBridge.kt
Show resolved
Hide resolved
webview/src/main/java/io/yubicolabs/funke_explorer/bridging/WalletJsBridge.kt
Outdated
Show resolved
Hide resolved
webview/src/main/java/io/yubicolabs/funke_explorer/credentials/SoftwareCredentialsContainer.kt
Outdated
Show resolved
Hide resolved
webview/src/main/java/io/yubicolabs/funke_explorer/credentials/SoftwareCredentialsContainer.kt
Outdated
Show resolved
Hide resolved
webview/src/main/java/io/yubicolabs/funke_explorer/credentials/SoftwareCredentialsContainer.kt
Outdated
Show resolved
Hide resolved
webview/src/main/java/io/yubicolabs/funke_explorer/credentials/SoftwareCredentialsContainer.kt
Outdated
Show resolved
Hide resolved
mariobodemann
force-pushed
the
feature/hints
branch
from
2496885 to
5435313
Compare
the ble functionality is integrated into the frontend now, so no need for explicit calles in the wrapper.
prepare using github issues.
# Conflicts: # .github/workflows/push.yml
mariobodemann
force-pushed
the
feature/hints
branch
from
3aca19f to
994db2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details see https://www.w3.org/TR/webauthn-3/#enum-hints .