Skip to content

Handle issuance edge cases + Credential issuance refactoring #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
patatoid wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle issuance edge cases + Credential issuance refactoring #182

patatoid wants to merge 1 commit into from

Conversation

@patatoid
Copy link
Contributor

@patatoid patatoid commented Jul 9, 2025

Here error management of credential issuance is improved to handle edge cases highlighted performing integration tests.

Changes

  • throw and rescue CredentialIssuanceError to have standard invalid_request responses at credential issuance
  • moved attestation proof validations within proofJwtVerification
  • moved dpop and proof validations in a try / catch block rescuing only known errors

@patatoid patatoid requested a review from a team as a code owner July 9, 2025 09:15
@patatoid patatoid changed the title Handle issuance edge cases + Credential issuance refactoring #163 Handle issuance edge cases + Credential issuance refactoring Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@patatoid