[NUOPEN-304] Change the reply-to for instrument training request email notifications to the customer's email #5904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… site default to the customer's email Change the reply-to for instrument issue email notifications from the site default to the customer's email similar to UMass-239
stevens101
requested review from
LeticiaErrandonea,
diebas and
joaquinco
as code owners
stevens101
changed the title
stevens101
changed the title
Collaborator
|
Hi @stevens101! This looks good to me and I think we can get this to the Open repo. Would you mind opening the PR there? Thank you! |
Collaborator
Author
|
yes, I will do that. sometimes github makes my brain explode. |
Collaborator
|
Oh, sorry! 🤦♀️ You're already in Open, I completely misread this |
LeticiaErrandonea
approved these changes
Dec 23, 2025
…r-instrument-issue-email-notifications-to-the-customer's-email
joaquinco
approved these changes
Dec 24, 2025
| reply_to = @user.email | ||
| if @product.training_request_contacts.any? | ||
| mail(to: @product.training_request_contacts, subject: t("training_request_mailer.notify_facility_staff.subject", facility: @product.facility)) | ||
| mail(to: @product.training_request_contacts, reply_to: reply_to, subject: t("training_request_mailer.notify_facility_staff.subject", facility: @product.facility)) |
Collaborator
There was a problem hiding this comment.
nit: you can use the hash shorthand syntax (omit the value) , reply_to:, subject: ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the reply-to for instrument training request email notifications from the site default to the customer's email similar to UMass-239