[NUOPEN-287] Document missing feature flags #5917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
LeticiaErrandonea
left a comment
LeticiaErrandonea
left a comment
There was a problem hiding this comment.
Left a few comments
doc/HOWTO_feature_flags.md
Outdated
Comment on lines
93
to
94
| * `auto_end_reservations_on_next_start` Automatically end previous reservations for timer/relay controlled instruments, when another user starts a new reservation. | ||
| * `auto_end_reservations_on_next_start`: Automatically ends an unfinished reservation if another reservation for the same instrument is started. |
Collaborator
There was a problem hiding this comment.
auto_end_reservations_on_next_start is repeated
doc/HOWTO_feature_flags.md
Outdated
| * `cross_facility_reports` Allow generating cross facility reports (does not work with SES due to attached file size limits) | ||
| * `kiosk_view` Kiosk mode - display a list of actionable reservations without logging in (optionally allow acting w/o auth) | ||
| * `reservations: grace_period`, `reservations: timeout_period`, `occupancies: timeout_period`, `billing: review_period` various grace periods, time periods, and review periods | ||
| * `bypass_kiosk_auth`: Do not require authentication on Kioks view actions. |
Collaborator
There was a problem hiding this comment.
Suggested change
| * `bypass_kiosk_auth`: Do not require authentication on Kioks view actions. | |
| * `bypass_kiosk_auth`: Do not require authentication on Kiosk view actions. |
doc/HOWTO_feature_flags.md
Outdated
|
|
||
| * `create_users` Should admins be able to manually add users | ||
| * `devise/lock_strategy`Lock account after 5 failed attempts | ||
| * `lookup_netids`: If enabled, allow internal and external users to be created. Add additional step to ensure the NetId or email is not already present. Else, navigate to create external user (no internal user creation allowed). |
Collaborator
There was a problem hiding this comment.
This else is for when the FF is off? Can we be more explicit? The sentence between the if and else is a bit confusing for me.
LeticiaErrandonea
approved these changes
Dec 31, 2025
Collaborator
LeticiaErrandonea
left a comment
LeticiaErrandonea
left a comment
There was a problem hiding this comment.
LGTM, thanks for the changes!
I think we can ignore the failing specs 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Add missing feature flags to documentaiton and restructure the sections.
NUOPEN-287 | Document feature flags