[NU-450] Make instruments sharing relay update status at the same time #5927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaquinco
reviewed
Jan 9, 2026
app/models/relay.rb
Outdated
Comment on lines
51
to
53
| Relay.unscoped | ||
| .where(host:, outlet:, ip_port:) | ||
| .where.not(id: nil) # Exclude unsaved records |
Collaborator
There was a problem hiding this comment.
I think this can just be Relay.where(host:, outlet:, ip_port:)
app/models/instrument_status.rb
Outdated
Comment on lines
51
to
53
| valid_instruments = shared_instruments.select do |inst| | ||
| inst.id.present? && inst.relay&.networked_relay? | ||
| end |
Collaborator
There was a problem hiding this comment.
I think we can safely assume all relays returned are valid. I don't see why the instrument id would be blank or there would be non-network relays with a host
app/models/instrument_status.rb
Outdated
Comment on lines
69
to
75
| missing_ids.each do |inst_id| | ||
| missing_instrument = valid_instruments.find { |inst| inst.id == inst_id } | ||
| next unless missing_instrument | ||
|
|
||
| status = find_or_initialize_by(instrument: missing_instrument) | ||
| status.update!(is_on:, updated_at: now) | ||
| end |
Collaborator
There was a problem hiding this comment.
nit: missing_ids.each { |instrument_id| find_or_initialize_by(instrument_id:).update(is_on:, updated_at: no) }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
NU-450 | Relay check update for shared schedules