Skip to content

Add ability to upload mappings/symbols file#26

Open
mateuszkwiecinski wants to merge 5 commits intowzieba:masterfrom
mateuszkwiecinski:upload_mappings
Open

Add ability to upload mappings/symbols file#26
mateuszkwiecinski wants to merge 5 commits intowzieba:masterfrom
mateuszkwiecinski:upload_mappings

Conversation

@mateuszkwiecinski
Copy link
Contributor

@mateuszkwiecinski mateuszkwiecinski commented Sep 7, 2020

Fixes #12

An attempt to include mappings/symbols file on action run

Comment on lines +72 to +73
appName: ${{ secrets.IOS_APP_NAME }}
token: ${{ secrets.IOS_API_TOKEN }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS apps cannot be uploaded to the same project as android ones

Comment on lines +9 to +13
RUN wget -q "https://dl.google.com/dl/android/maven2/com/android/tools/build/aapt2/4.0.1-6197926/aapt2-4.0.1-6197926-linux.jar" -O aapt2-all.jar \
&& mv aapt2-all.jar /usr/local/lib/aapt/aapt2-all.jar \
&& cd /usr/local/lib/aapt \
&& unzip -qq aapt2-all.jar \
&& ln -s /usr/local/lib/aapt/aapt2 /usr/local/bin/aapt2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the [documentation(https://developer.android.com/studio/command-line/aapt2#download_aapt2) to use aapt it is required to download the jar and extract it. The jar itself isn't executable 🤷

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thing here is the location where the jar file is extracted to.
I could extract the file into the working directory as it gets bound as a volume (which makes me thinking if COPY . /app is actually needed if all the content gets immediately ovewritten 🤔)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And one more thing is that I'm creating a symlink on a path that belongs to PATH as I wanted to make it executable everywhere, but for some reason I couldn't make it to work 🤷 If anyone has any idea why it didn't work in the bash script I'd love to know.

README.md Outdated
### `appName`

**Required** App name followed by username e.g. `wzieba/Sample-App`
**Required** App name preceded by the App Center's username e.g. wzieba/Sample-App
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it wasn't clear for me what the username is. I have an account created using google sign in so in my case there was some.weirdshit-domaincom. I thought it might make sense to update the documentation here as well

@mateuszkwiecinski mateuszkwiecinski changed the title Ad ability to upload mappings/symbols file Add ability to upload mappings/symbols file Sep 8, 2020
@mateuszkwiecinski mateuszkwiecinski marked this pull request as ready for review September 8, 2020 12:31
@wzieba wzieba mentioned this pull request Apr 21, 2021
@wzieba wzieba mentioned this pull request Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upload mapping files

2 participants