-
Notifications
You must be signed in to change notification settings - Fork 73
GlobalContributions: Highlight pending edits (FlaggedRevs extension) #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #531 +/- ##
============================================
- Coverage 71.30% 69.56% -1.75%
- Complexity 1275 1325 +50
============================================
Files 46 46
Lines 3792 3982 +190
============================================
+ Hits 2704 2770 +66
- Misses 1088 1212 +124 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Oh hang on, this may have a problem: getting the extensions of 1 project is 1 api call. From quick testing, these api calls each take 0.3-08 seconds. Let's say average 0.5. That means, for someone that has edited 50 projects, or 5% of all projects, 50 seconds of waiting time. That's not good. |
|
Similarly to the fix for #568 , normally we should be able to check having or not flaggedrevs simply with |
Changes are roughly:
Bug: T322466