-
Notifications
You must be signed in to change notification settings - Fork 76
EditCounter: integrate flaggedrevs in protection counts #534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #534 +/- ##
============================================
- Coverage 71.30% 69.49% -1.82%
- Complexity 1275 1326 +51
============================================
Files 46 46
Lines 3792 3924 +132
============================================
+ Hits 2704 2727 +23
- Misses 1088 1197 +109 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MusikAnimal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to merge in main for this to work, FYI.
Two problems:
- We shouldn't count moving a protection as a protection modification (see comments)
- The UI will make the counts link to Special:Log for the specific type and action. In this case, we're counting from two different logs, so there's no single place to link to :( Maybe it doesn't really matter, but I imagine someone will eventually point out the discrepancy. What do you think? Maybe FlaggedRevs counts should be separate from the (re-)protect counts?
We've been doing it like this in adminstats for a while and no one seems to mind, with the only complaint being that we don't do the same in EC, so I gather it'll be fine. |
Of course, FlaggedRevs' documentation is not much to go on, but from logs and quarry &c it looks like there are four actions of type
stable:config: apparently sets pending changes, so I bundled it in protectionmodify: obviously goes with reprotectionmove_stable: bundled it too with reprotectionreset: I'm pretty sure this is unprotection.Bug: T284876