Skip to content

Conversation

@agoujot
Copy link
Member

@agoujot agoujot commented May 27, 2025

Of course, FlaggedRevs' documentation is not much to go on, but from logs and quarry &c it looks like there are four actions of type stable:

  • config: apparently sets pending changes, so I bundled it in protection
  • modify: obviously goes with reprotection
  • move_stable: bundled it too with reprotection
  • reset: I'm pretty sure this is unprotection.

Bug: T284876

@codecov
Copy link

codecov bot commented May 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.49%. Comparing base (4b8eb28) to head (f8a49bb).
⚠️ Report is 186 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #534      +/-   ##
============================================
- Coverage     71.30%   69.49%   -1.82%     
- Complexity     1275     1326      +51     
============================================
  Files            46       46              
  Lines          3792     3924     +132     
============================================
+ Hits           2704     2727      +23     
- Misses         1088     1197     +109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@MusikAnimal MusikAnimal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to merge in main for this to work, FYI.

Two problems:

  • We shouldn't count moving a protection as a protection modification (see comments)
  • The UI will make the counts link to Special:Log for the specific type and action. In this case, we're counting from two different logs, so there's no single place to link to :( Maybe it doesn't really matter, but I imagine someone will eventually point out the discrepancy. What do you think? Maybe FlaggedRevs counts should be separate from the (re-)protect counts?

@agoujot
Copy link
Member Author

agoujot commented Oct 21, 2025

The UI will make the counts link to Special:Log for the specific type and action. In this case, we're counting from two different logs, so there's no single place to link to :( Maybe it doesn't really matter, but I imagine someone will eventually point out the discrepancy. What do you think? Maybe FlaggedRevs counts should be separate from the (re-)protect counts?

We've been doing it like this in adminstats for a while and no one seems to mind, with the only complaint being that we don't do the same in EC, so I gather it'll be fine.

@agoujot agoujot requested a review from MusikAnimal October 21, 2025 09:32
@agoujot agoujot requested a review from MusikAnimal October 26, 2025 10:53
@MusikAnimal MusikAnimal merged commit 1ba5624 into x-tools:main Oct 27, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants