Skip to content

Conversation

@agoujot
Copy link
Member

@agoujot agoujot commented Jul 23, 2025

This would also have been solved by a merge of #532 or #551 ; as these implement a cleaner separation between the raw data and the counts we're making. Until we get around to doing that, this is a simpler and smaller fix.

Bug: T400293

@codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.96%. Comparing base (4b8eb28) to head (ba4849b).
Report is 127 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #560      +/-   ##
============================================
- Coverage     71.30%   70.96%   -0.35%     
- Complexity     1275     1297      +22     
============================================
  Files            46       46              
  Lines          3792     3888      +96     
============================================
+ Hits           2704     2759      +55     
- Misses         1088     1129      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@agoujot
Copy link
Member Author

agoujot commented Jul 23, 2025

(The root problem is that I had assumed that the PHP array counting/filtering functions only read numeric keys. I think I thought that because it does that in JS.)

@agoujot agoujot merged commit 0f173ba into x-tools:main Jul 23, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant