Switch to MediaWiki coding style, use OpenAPI attributes #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MusikAnimal
force-pushed
the
mediawiki-coding-conventions
branch
3 times, most recently
from
9f7fea3 to
11a8094
Compare
MusikAnimal
changed the title
MusikAnimal
force-pushed
the
mediawiki-coding-conventions
branch
2 times, most recently
from
b531934 to
ba5c1a1
Compare
The convention now for methods with attributes is to have first the OpenAPI attributes (if applicable), the routing attributes, followed by the PHP doc block. Use more of PHP 8+ features like str_starts_with and first class callable syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The convention now for methods with attributes is to have first the
OpenAPI attributes (if applicable), the routing attributes, followed by
the PHP doc block.
Use more of PHP 8+ features like str_starts_with and first class
callable syntax.