Fix a typo

[NguoiDungKhongDinhDanh]

The last commit renamed loadinganimation to loadingAnimation without also changing the reference to that variable.

[DatGuy1]

+1, currently throwing an exception on every page after being synced earlier today. @NovemLinguae could this be expedited (in your capacity as a MediaWiki administrator)?

[NovemLinguae]

I don't have any access in this repo. @MusikAnimal would be the one to help with this one.

XTools is a Toolforge tool, so mediawiki wiki administrator rights probably aren't what's needed here.

[NovemLinguae]

Oh I see what you mean. The typo affects the 1% of this code that is also a gadget. I don't have interface administrator on mediawkiwiki, so would need to contact one of these folks: https://www.mediawiki.org/wiki/Special:ListUsers?group=interface-admin&wpsubmit=&wpFormIdentifier=mw-listusers-form&limit=500

@siddharthvp, you around? Sounds like this edit needs undoing or typo fixing: https://www.mediawiki.org/w/index.php?title=XTools/ArticleInfo.js&diff=prev&oldid=8120353

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.81%. Comparing base (4b8eb28) to head (7374eb9).
⚠️ Report is 222 commits behind head on main.

Additional details and impacted files

@@              Coverage Diff              @@
##               main     #602       +/-   ##
=============================================
- Coverage     71.30%   60.81%   -10.50%     
- Complexity     1275     1406      +131     
=============================================
  Files            46       46               
  Lines          3792     4305      +513     
=============================================
- Hits           2704     2618       -86     
- Misses         1088     1687      +599     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[siddharthvp]

@siddharthvp, you around? Sounds like this edit needs undoing or typo fixing: mediawiki.org/w/index.php?title=XTools/ArticleInfo.js&diff=prev&oldid=8120353

Looks like @pppery got there first.

[pppery]

(Actually it only requires admin not interface admin rights - the JS code on wiki is merely a protected page not a MediaWiki namespace page. This is unideal)

[MusikAnimal]

(Actually it only requires admin not interface admin rights - the JS code on wiki is merely a protected page not a MediaWiki namespace page. This is unideal)

Indeed. The old, old gadget was in the userspace. We moved it to its current canonical location before int-admin was a thing, so at the time the sysop protection was on par with the best practices. We could move it to a MW namespace page and do the same JS redirect as before, I guess. Maybe also emit a warning to the console, since I think there are still users importing Hedonil's original script. Probably not a significant issue but all those redirects are surely non-ideal.

[MusikAnimal]

I don't have any access in this repo. @MusikAnimal would be the one to help with this one.

I am going on sabbatical (it was supposed to have already started, but I digress…); @NovemLinguae Would you be interested in joining the team? I'm sure @agoujot could use some help while I'm out, and I of course trust you not to do something stupid :-P

[NovemLinguae]

Sure, go ahead, would be happy to help. Enjoy your sabattical (and I was wondering how you got a laptop to that Mexican beach you were talking about :P )

[MusikAnimal]

Sweet, thanks! I'll DM on you Discord.