Skip to content

WIP: use buttons for commands with a fixed set of values #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: beta
Choose a base branch
from

Conversation

jessicah
Copy link

@jessicah jessicah commented Aug 2, 2024

Not yet functional, intent is to provide buttons for DDC/CI that has a list of fixed values.

TODO:

  • Wire up buttons to trigger change
  • Add custom labels for buttons in settings window

Current proof of concept of UI flyout:
image

@xanderfrangos
Copy link
Owner

Been meaning to work on this for a while now, so I appreciate you stepping in to help!

My intent was to add an option to the new "DDC/CI Features" settings (per "feature"), allowing users to manually define values for a VCP code instead of using a slider. I was thinking of using a select box or context menu instead of buttons. That way, users could assign names and not worry about horizontal space. I figure that input selection would be the most common use case, followed by color temperature. Both of those would benefit from user-defined names.

I haven't had a chance to review this too much yet, but it looks like that's the general direction you're moving in already. LMK if you have any questions about getting things hooked up.

FYI, I don't recommend relying on Twinkle Tray's detection of available VCP codes for a display. It's only available under certain conditions, so users need to be able to define the VCP codes and values themselves.

@jessicah
Copy link
Author

jessicah commented Aug 4, 2024

How to you debug the app? I'm trying to get a working config in VS Code, but I'm not having any luck, which is making trying to fix CSS issues difficult, and generally relying on console.log is a bit painful.

I'm not sure I can deliver on all of those above, Electron/JS dev isn't my forte, but I'll see what I can do :)

For the custom VCP commands, maybe something like this would work (minus CSS fixing):
image

@xanderfrangos
Copy link
Owner

Sorry for the huge delay! Ctrl + I opens the inspector, which will help with debugging CSS. Don't worry too much about getting everything perfect visually. I'm happy for anything you can contribute.

@Muci3k
Copy link

Muci3k commented Feb 24, 2025

Od dłuższego czasu planowałem nad tym popracować, więc doceniam, że się w to zaangażowałeś!

Moim zamiarem było dodanie opcji do nowych ustawień "Funkcje DDC/CI" (na podstawie "funkcji"), umożliwiającej użytkownikom ręczne definiowanie wartości dla kodu VCP zamiast korzystania z suwaka. Myślałem o użyciu pola wyboru lub menu kontekstowego zamiast przycisków. W ten sposób użytkownicy mogliby przypisywać nazwy i nie martwić się o przestrzeń poziomą. Uważam, że wybór wejścia byłby najczęściej używanym przypadkiem, a następnie temperatura kolorów. Oba te przypadki skorzystałyby z nazw definiowanych przez użytkownika.

Nie miałem jeszcze okazji zbyt dokładnie tego przejrzeć, ale wygląda na to, że to ogólny kierunek, w którym już zmierzasz. Daj znać, jeśli masz jakieś pytania dotyczące podłączenia rzeczy.

FYI, nie polecam polegania na wykrywaniu dostępnych kodów VCP przez Twinkle Tray dla wyświetlacza. Jest to dostępne tylko w określonych warunkach, więc użytkownicy muszą być w stanie samodzielnie zdefiniować kody i wartości VCP.

It would be great to have an option to select the appropriate DDC/CI setting via radio buttons or a simple button. Additionally, it should be possible to assign these settings to a previously created profile.

My goal is to automate profile switching based on the games I launch, so that the monitor settings adjust automatically. Since I have two monitors from different brands, official software is not a viable solution.

This feature would allow for a seamless experience when switching between different games with different display preferences. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants