Bug fixes on some translations and compilations#433
Bug fixes on some translations and compilations#433pbodq2 wants to merge 4 commits intoxbmc:masterfrom
Conversation
Remove non standarded area code file names. Enrich translation content.
pbodq2
changed the title
ECO plugin conversion compatibility problems workarounds: 1.Relocate escape characters. 2.Change nested indent blocks into one singal line.
| <div class="item-inner item-<%= @type %>"> | ||
| <div class="artwork"> | ||
| <div class="thumb" title="<%= @label %>" style="background-image: url('<%= @thumbnail %>')"> | ||
| <div class="thumb" title="<%= @label %>" style="background-image: url(<%= '\'' + @thumbnail + '\'' %>)"> |
There was a problem hiding this comment.
The web playlist is already fully broken in v19 RC1 Chorus2 v2.4.7 BEFORE I submit this change. This change is not dealing with that.
The web playlist in CoreELEC v9.2.5 with Kodi v18.9 , Chorus2 v2.4.6 is half broken. You can temp add items but items won't be saved into a new list form.
I may look into this part later and compare the code changes during these 2 years.
This type of escape character compilation errors exists on MACOS only, not author's Docker ubuntu dev, even though both platforms equipped with all the same library versions.
|
More information about "Fix ECO template compilation errors", these errors do not occur in author's Docker's container environment, i.e. node.js v8.12.0 npm v6.4.1 We can reproduce them in newer versions like node.js v14.15.4 npm v6.14.10 (all other package versions keep constant) You guys may consider whether it is necessary to adopt it or leave it unchanged for better consistency. |
|
@gade01 now that this is translatable via weblate can you do the follow up to this issue and close it? |
|
@enen92 @pbodq2
|
4 participants
No description provided.