Open
Conversation
malard
reviewed
Jan 29, 2024
Contributor
malard
left a comment
There was a problem hiding this comment.
i'm not sure how this works to not commit these back in to the repo? We need these generated files to create the actual files that will be used in a release and also to push into xbmc/xbmc ?
Those files are generated during the build process. Therefore they shouldn't be tracked.
Member
Author
|
The files are added to the Currently there is the situation, that those files don't match the actual state of the input source files for a specific commit. Contributors could think they've to update both files (source and generated). |
Contributor
|
So are you saying that we need to delete the existing files in the repo also? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those files are generated during the build process.
Therefore they shouldn't be tracked.