Skip to content

Conversation

wellspokenman
Copy link

Description

Kodi 21 Support, Fixed IMDb parsing of Oscars, Fixed Wikipedia scraping for stand-up comedians, Fixed Trakt authentication

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practise but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

…ng for stand-up comedians, Fixed Trakt authentication

:return: A 2-tuple of client_id, client_secret
"""
print('If you do not have a client ID and secret. Please visit the '
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not use direct print() function. Use xbmc.log() instead.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any error relevant for the user is communicated via xbmc.log, these print statements are from the trakt library that I require for the oauth flow. I can comment them out if you like?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I strongly recommend moving all the code into an importable module leaving only a small entrypoint code here. It will speed-up addon start on lower-end systems like Raspberry Pi or various Android TV boxes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i had a go, but this is a major rewrite. All the variables will need to be moved then I have to test it all again.

@romanvm
Copy link

romanvm commented Aug 30, 2025

Please check my comments.

@wellspokenman
Copy link
Author

Please check my comments.

I've looked into moving the code as you suggest, but this is more work than I have time for right now. This is an old addon that ran ok on rasperry pi a decade ago - if it was good enough for Kodi Frodo I don't understand why it isn't sufficiently performant for Omega. The trakt library is only ever accessed within a try catch that has Kodi logs and gui errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants