Skip to content

Conversation

@klmp200
Copy link

@klmp200 klmp200 commented Nov 14, 2025

Avoid python version mismatch that pulls incompatible dependencies in github actions when running unittests

@stormi
Copy link
Member

stormi commented Nov 14, 2025

Can you specify in the commit message what you designate as "CI"? This can be several different things: github actions, RPM %check, xcp-ng-tests runs...

@klmp200 klmp200 force-pushed the fix_ci branch 2 times, most recently from a652b7f to 8d6d05e Compare November 14, 2025 14:40
@klmp200 klmp200 changed the title fix(ci): use a python version closest to the one in production chore(ci): use a python version closest to the one in production Nov 20, 2025
Avoid python version mismatch that pulls incompatible dependencies in github actions when running unittests

Signed-off-by: Antoine Bartuccio <antoine.bartuccio@vates.tech>
@klmp200 klmp200 marked this pull request as ready for review November 20, 2025 14:56
uses: actions/setup-python@v4
with:
python-version: '3.x'
python-version: '3.8' # This is the closest available to 3.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More explicit + correction regarding the used version:

This version is the closest available to the one currently used in production (3.6).

@Wescoeur
Copy link
Member

Regarding the commit message, small suggestion:

chore(ci): build using python 3.8
Avoid python version mismatch that pulls incompatible dependencies in github actions when running unittests.

You can also explain why the coverage version is no longer forced. Regarding chore(ci) as discussed internally, it doesn't bother me if we can format the patches for the RPM while ignoring these commits with this prefix. If we can't manage that, we should explicitly state that it's the GitHub workflow. Otherwise, if it's ok I don't think there can be any misunderstanding about the term "CI."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants