Rebase on xenserver-release-8.4.0-18.xs8.src.rpm #51
Conversation
* Thu Mar 13 2025 Gerald Elder-Vass <gerald.elder-vass@cloud.com> - 8.4.0-18 - CA-407370: Separate rsyslog configs for xenserver and customer (yes, the tarball version doesn't match the changelog entry, but both the tarball version and the SRPM release number are right) Signed-off-by: Samuel Verschelde <stormi-xcp@ylix.fr>
stormi
force-pushed
the
8.3-rebase-XS-20250922
branch
from
46a0c24 to
f34cd5a
Compare
|
I suggest to have the main discussion on xcp-ng-rpms/xcp-ng-release#33 where the full change can be seen at once. |
stormi
force-pushed
the
8.3-rebase-XS-20250922
branch
from
f34cd5a to
25cc608
Compare
|
Now ready for review |
* Mention XCP-ng in addition to XenServer. I didn't completely replace XenServer with XCP-ng. After all, the file is still named xenserver.conf, so that would be awkward. * Do NOT invite users to edit /etc/rsyslog.d/remote.conf, which is managed by XAPI. * Discourage any custom modifications, but in the case where it's unavoidable, redirect them to /etc/rsyslog.d/custom.conf, after validation by technical support. Signed-off-by: Samuel Verschelde <stormi-xcp@ylix.fr>
stormi
force-pushed
the
8.3-rebase-XS-20250922
branch
from
25cc608 to
b437967
Compare
|
Converted to draft. We decided to hold back this change and work on a better solution. |
| # Any other rsyslog configuration change must be avoided. | ||
| # However, if there are no other options, they must be evaluated with technical support | ||
| # representatives, and written to a file named /etc/rsyslog.d/custom.conf. | ||
| # Note that there are no guarantees regarding the order in which rules from different |
There was a problem hiding this comment.
Are you sure ? see
xcp-ng-rpms/xcp-ng-release#33 (comment)
I would make rules from custom.conf parsed after remote.conf and before xenserver.conf.
This can be easly achieved by just renaming custom.conf to user-*.conf files
There was a problem hiding this comment.
So I read https://www.rsyslog.com/doc/configuration/global/options/rsconf1_includeconfig.html and it's not clear to me whether the rule they describe applies when you specify a directory, rather than directory/*.conf.
There was a problem hiding this comment.
I see no point in having the custom rules parsed between remote.conf and xenserver.conf. To me, either we want them parsed before (and then our defaults to still get applied on top), or at the very end (zz-custom.conf).
It looks like a good change, being clear about what belongs to default configuration you shouldn't touch and what belongs to user configuration.
We need to be careful about potential effects of not removing default rules anymore, but I haven't checked the changes in the SRPM itself.