Add tests for corruption recovery on LINSTOR SR #360
+142
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests DRBD's corruption recovery using drbdadm verify and invalidate-remote commands as well as basic VM operations (startup, snapshot, shutdown) Signed-off-by: Mathieu Labourier <mathieu.labourier@vates.tech>
- add missing type hints in function declarations - rename wait_sync to wait_drbd_sync - rename single letter variables Co-authored-by: Antoine Bartuccio <antoine.bartuccio@vates.tech> Signed-off-by: Mathieu Labourier <mathieu.labourier@vates.tech>
Millefeuille42
force-pushed
the
mlr/629-xostor-drbdadm-verify
branch
from
e65c96c to
5af35f6
Compare
klmp200
approved these changes
Nov 7, 2025
rzr
reviewed
Nov 27, 2025
|
|
||
| def get_drbd_status(host: Host, resource: str): | ||
| logging.debug(f"[{host}] Fetching DRBD status for resource `{resource}`...") | ||
| return json.loads(host.ssh(["drbdsetup", "status", resource, "--json"])) |
There was a problem hiding this comment.
would split this line, but you probably know what you are doing more than myself :)
rzr
reviewed
Nov 27, 2025
| ] | ||
|
|
||
| def wait_drbd_sync(host: Host, resource: str): | ||
| logging.info(f"[{host}] Waiting for DRBD sync on resource `{resource}`...") |
There was a problem hiding this comment.
This works but pylint dont like fstrings: W1203: Use lazy % formatting in logging functions (logging-fstring-interpolation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests DRBD's corruption recovery using drbdadm verify and invalidate-remote commands as well as basic VM operations (startup, snapshot, shutdown)