Fix truncation of erroneous samples / clock measurements#158
Merged
cbrnr merged 3 commits intoxdf-modules:mainfrom Jan 12, 2026
Merged
Fix truncation of erroneous samples / clock measurements#158cbrnr merged 3 commits intoxdf-modules:mainfrom
cbrnr merged 3 commits intoxdf-modules:mainfrom
Conversation
Contributor
Author
|
@cbrnr This is good for review- I checked some more XDF files today. The updated logic is more conservative. It still correctly handles the |
Contributor
|
Thanks @mscheltienne! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #150- there was one assumption in this PR and of course it turns out to be wrong.. 😞
#150 assumes that the
sample_countin the footer is correct; and thus it detects the anomaly by:sample_count_detect_corrupted_clock_offset).We found a file where the
sample_countwasn_sampels - 1, thus the last sample got truncated.. and yet it's a perfectly valid sample. Then workflow https://github.com/xdf-modules/pyxdf/actions/runs/20859146756/job/59933968045 highlights a case where an anomalous clock offset measurement is present, but without extra samples. So, this PR modifies the logic to: