dialects: (math) folders for floating point operations#5310
Draft
dialects: (math) folders for floating point operations#5310
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5310 +/- ##
==========================================
- Coverage 85.67% 85.49% -0.18%
==========================================
Files 373 373
Lines 52997 53138 +141
Branches 6019 6046 +27
==========================================
+ Hits 45403 45431 +28
- Misses 6139 6251 +112
- Partials 1455 1456 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
seems like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I mostly limited myself to simple floating point operations that have a clear python counterpart. Only does folding with constant operands. No other identities are taken into account.
Open questions:
I'm wondering if these folders should work for types other than f64 (like I currently made them to)?
Also, any proposal on how to test it. Just with a single arbitrary input and checking they match the python function?