Skip to content

core: use closure to parse bare id in affine expr parsing#5464

Merged
superlopuh merged 1 commit intomainfrom
sasha/affine/parse-id-refactor
Nov 22, 2025
Merged

core: use closure to parse bare id in affine expr parsing#5464
superlopuh merged 1 commit intomainfrom
sasha/affine/parse-id-refactor

Conversation

@superlopuh
Copy link
Member

PR 1/2 of adding the necessary parsing infrastructure to be able to express affine.vector_load/store (#5365).

@superlopuh superlopuh self-assigned this Nov 21, 2025
@superlopuh superlopuh added the core xDSL core (ir, textual format, ...) label Nov 21, 2025
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 87.17949% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.87%. Comparing base (6b63574) to head (0890457).
⚠️ Report is 177 commits behind head on main.

Files with missing lines Patch % Lines
xdsl/parser/affine_parser.py 87.17% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5464   +/-   ##
=======================================
  Coverage   85.87%   85.87%           
=======================================
  Files         382      382           
  Lines       54899    54911   +12     
  Branches     6320     6321    +1     
=======================================
+ Hits        47142    47155   +13     
  Misses       6248     6248           
+ Partials     1509     1508    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know that much affine parsing, but I trust you otherwise (probably someone that understands this should review this as well)

@superlopuh superlopuh merged commit 416734a into main Nov 22, 2025
23 checks passed
@superlopuh superlopuh deleted the sasha/affine/parse-id-refactor branch November 22, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core xDSL core (ir, textual format, ...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants