core: use closure to parse bare id in affine expr parsing#5464
Merged
superlopuh merged 1 commit intomainfrom Nov 22, 2025
Merged
core: use closure to parse bare id in affine expr parsing#5464superlopuh merged 1 commit intomainfrom
superlopuh merged 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5464 +/- ##
=======================================
Coverage 85.87% 85.87%
=======================================
Files 382 382
Lines 54899 54911 +12
Branches 6320 6321 +1
=======================================
+ Hits 47142 47155 +13
Misses 6248 6248
+ Partials 1509 1508 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
math-fehr
approved these changes
Nov 22, 2025
Collaborator
math-fehr
left a comment
There was a problem hiding this comment.
I don't know that much affine parsing, but I trust you otherwise (probably someone that understands this should review this as well)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 1/2 of adding the necessary parsing infrastructure to be able to express
affine.vector_load/store(#5365).