dialect: (eqsat_pdl_interp) Move eqsat_pdl_interp operations to their own dialect#5474
Merged
dialect: (eqsat_pdl_interp) Move eqsat_pdl_interp operations to their own dialect#5474
Conversation
jumerckx
force-pushed
the
jumerckx/eqsat_pdl_interp
branch
from
8036cfa to
aba8f4b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5474 +/- ##
========================================
Coverage 85.98% 85.98%
========================================
Files 388 389 +1
Lines 55396 55627 +231
Branches 6378 6400 +22
========================================
+ Hits 47631 47832 +201
- Misses 6250 6265 +15
- Partials 1515 1530 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
superlopuh
reviewed
Nov 26, 2025
jumerckx
force-pushed
the
jumerckx/eqsat_pdl_interp
branch
from
a8e35aa to
351f4b6
Compare
superlopuh
reviewed
Nov 30, 2025
Collaborator
Author
|
CI is green! |
superlopuh
reviewed
Dec 13, 2025
superlopuh
reviewed
Dec 13, 2025
| # "custom<CreateOperationOpResults>($inputResultTypes, type($inputResultTypes), $inferredResultTypes)" | ||
| # "attr-dict" | ||
| # ) | ||
| # TODO: this assebly format is unsupported in xDSL because of the `custom` directives. |
Member
There was a problem hiding this comment.
We actually now support custom directives! I wonder if it would be worth first fixing that quickly in another PR then merging this one? This is your call, we can also merge this now and clean up later, since the custom syntax already works.
Collaborator
Author
There was a problem hiding this comment.
I'll merge this first as just uncommenting the assembly_format still throws.
superlopuh
approved these changes
Dec 13, 2025
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr also includes
convert-pdl-interp-to-eqsat-pdl-interpwhich is used byapply-eqsat-pdland converts each of thepdl_interpoperations to the equivalent ineqsat_pdl_interp.I just copied over the operation definitions. In the future these dialects are supposed to diverge.